duplicates - C++ Calculating shipping cost based on weight -

-

part of program i'm working on implements function takes in package weight argument , calculates shipping cost based on weight. criteria cost/lb follows: 

        package weight              cost         --------------              ----         25 lbs & under              $5.00 (flat rate)         26 - 50 lbs                 above rate + 0.10/lb on 25         50 + lbs                    above rate + 0.07/lb on 50

i used if-if else-if make calculations, feel bit repetitive:

const int tier_2_weight = 25; const int tier_3_weight = 50;  const float tier_1_rate = 5.00; const float tier_2_rate = 0.10; const float tier_3_rate = 0.07;  float shippricef;   if(shipweightf <= tier_2_weight) {     shippricef = tier_1_rate; } else if(shipweightf <= tier_3_weight) {     shippricef = ((shipweightf - tier_2_weight) * tier_2_rate) +                    tier_1_rate; } else {     shippricef = ((shipweightf - tier_3_weight) * tier_3_rate)   +                  ((tier_3_weight - tier_2_weight) * tier_2_rate) +                    tier_1_rate; }  return shippricef;

so, question is... best way accomplish task, or should looking different solution?

first @ all, code looks clear , ok is.

of course, deduplicate redundant parts of formulas using cumulative approach: 

float shippricef = tier_1_rate; // paid anyway  if (shipweightf > tier_2_weight) // add tier 2 if necessary {     shippricef += (min(shipweightf, tier_3_weight) - tier_2_weight) * tier_2_rate; } if(shipweightf > tier_3_weight)  // add tier 3 if necessary {     shippricef += (shipweightf - tier_3_weight) * tier_3_rate); }

well, simplified further: 

float shippricef = tier_1_rate                       + max(min(shipweightf,tier_3_weight)-tier_2_weight,0) * tier_2_rate                       + max(shipweightf-tier_3_weight,0) * tier_3_rate;

for 3 scales, it's ok synthetic formula. if want more flexibility however, think of iterating throug vector of rates instead of using constants. allow variable number of scales. if you're sure formula progressive (eg. "above + new unit price what's exceding") use cumulative approach.


Comments

Post a Comment

Popular posts from this blog

jsf - "PropertyNotWritableException: Illegal Syntax for Set Operation" error when setting value in bean -

-
this question has answer here: how send form input values , invoke method in jsf bean 1 answer i error when trying send values jsf page bean. i want set values fields in bean, create airplane instance , add database. error telling me use illegal syntax setter part of bean. why error? didnt find on site helped me problem. here jsf part: <h4>add plane</h4> <c:if test="#{not empty listairplanebb.error}"> <div class="alert alert-danger"> <span class="glyphicon glyphicon-remove"></span> <h:outputtext value="#{listairplanebb.error}" /> </div> </c:if> <h:form> <table class="table"> <thead> ...
Read more

arrays - Algorithm to find ideal starting spot in a circle -

-
so problem have been debating such: your given array of integers representing circle. then, have pick spot in circle start. place start, compare value @ array number of steps took there , if steps less or equal number, include in final set. find place start have elements in set. ex, a=[0, 1, 2] if start @ index=0, then: a[0]=0 < =0 0 included a[1]=1 < =1 1 included a[2]=2 < =2 2 included final set: {0,1,2} if start @ index=1, then: a[1]=1 > 0 1 not included a[2]=2 > 1 2 not included here loop around a[0]=0 > 2 0 included final set: {0} if start @ index=2, then: a[2]=2 > 0 2 not included, here loop around a[0]=0 < = 1 0 included a[1]=1 < = 2 1 included final set: {0,1} so in trivial case, starting position index=0 best position results in final set elements. brute force method of finding obvious, trying find more efficient method. attempts far have been examine trying find max intersect of viable starting ranges calculated each element in arr...
Read more

php - Autoloader issue not returning Class -

-
problem? bootloader (autoloader) not seem working properly, or i'm missing something. here simplified code. the code below returns class "skeleton" not exist. on index.php file. index.php <?php include 'bootloader.php'; use skeleton\html\loginheader; $tool = new skeleton/html/loginheader(); bootloader.php <?php function boot($classname) { $filename = ''; $namespace = ''; // sets include path "src" directory $includepath = dirname(__file__).directory_separator.'src'; if (false !== ($lastnspos = strripos($classname, '\\'))) { $namespace = substr($classname, 0, $lastnspos); $classname = substr($classname, $lastnspos + 1); $filename = str_replace('\\', directory_separator, $namespace) . directory_separator; } $filename .= str_replace('_', directory_separator, $classname) . '.php'...
Read more