nested for loop java poker game arraylist constructor -


this constructor far deck of 45 cards i'm writing basic constructor should make deck of 45 cards suit values (0-spades, 1-hearts, 2-clubs, 3-diamonds, 4-madeupname) , card values (1-9 1 ace)

private arraylist cards;

public deck() {     cards = new arraylist <card>();      (int valuekind = 1; valuekind<9; valuekind++){          card newcard = new card(valuekind,0);          cards.add(newcard);      }     (int valuekind = 1; valuekind<9; valuekind++){          card newcard = new card(valuekind,1);          cards.add(newcard);      }     (int valuekind = 1 ; valuekind<9; valuekind++){          card newcard = new card(valuekind,2);          cards.add(newcard);      }      (int valuekind = 1; valuekind<9; valuekind++){          card newcard = new card(valuekind,3);          cards.add(newcard);      }      (int valuekind = 1; valuekind<9; valuekind++){          card newcard = new card(valuekind,4);          cards.add(newcard);      }  

what's wrong/missing?

if want create value 1 - 9, loop in wrong condition. should <= 9

i made improvement code, cleaner , fix bug <= 9

import java.util.arraylist; import java.util.list;  /**  * created hendrawd on 11/13/16.  */ public class deck {     list<card> cards;      public deck() {         cards = new arraylist<>();         makecards(card.spade);         makecards(card.heart);         makecards(card.club);         makecards(card.diamond);         makecards(card.madeupname);     }      private void makecards(int type) {         (int valuekind = 1; valuekind <= 9; valuekind++) {             card newcard = new card(valuekind, type);             cards.add(newcard);         }     } }  class card {     static final int spade = 0;     static final int heart = 1;     static final int club = 2;     static final int diamond = 3;     static final int madeupname = 4;      private int value, type;      card(int value, int type) {         this.value = value;         this.type = type;     } } 

Comments

Popular posts from this blog

php - How to display all orders for a single product showing the most recent first? Woocommerce -

asp.net - How to correctly use QUERY_STRING in ISAPI rewrite? -

angularjs - How restrict admin panel using in backend laravel and admin panel on angular? -